davidherney / moodle-format_onetopic

Course format Onetopic to LMS Moodle
GNU General Public License v3.0
19 stars 42 forks source link

Code checker updates, including for Moodle 4.2 #148

Closed james-cnz closed 9 months ago

james-cnz commented 1 year ago

Moodle 4.2 is released, so that can be checked now. There is a new version of the CI plugin, but it doesn't support PHP 7.3, so the old version needs to be used for checking PHP 7.3. See https://moodlehq.github.io/moodle-plugin-ci/UPGRADE-4.0.html I thought maybe it would be good to alternate between checking PostgreSQL and MariaDB. GitHub has updated their checkout code, so that needs to be changed. See https://github.com/moodlehq/moodle-plugin-ci/pull/190 The example CI script changed the command for calling the code checker, so may as well do that. See https://github.com/moodlehq/moodle-plugin-ci/pull/212 May as well include the comment that's been added to the example CI script too.

davidherney commented 9 months ago

Hi @james-cnz...

Thanks for the changes.

I had to integrate the changes manually because I separated version 4.1 from 4.2.

Saludos