Fix for PHP 5.6 (Moodle 3.3 minimum requirement)

davidherney / moodle-format_onetopic

Course format Onetopic to LMS Moodle

GNU General Public License v3.0

19 stars 44 forks source link

Fix for PHP 5.6 (Moodle 3.3 minimum requirement) #78

Closed james-cnz closed 3 years ago

james-cnz commented 4 years ago

I think it looks like PHP 5.6 support was broken when privacy provider support was added. (PHP 5.6 is Moodle 3.3's minimum requirement.) I guess it's probably not really an issue, since no-one's filed a bug report, but since it's only a small change, may as well do it anyway?

davidherney commented 3 years ago

Hi @james-cnz...

Can you set the pull request to MOODLE_33 branch? not to the master because the master branch is for the last Moodle versions and it is not compatible with PHP < 7. I can do it manually but I want accept your contribution.

Saludos

james-cnz commented 3 years ago

Hi @davidherney,

I'm away from home for a few days, and don't have my computer, just my phone, so I can't redo the pull request. It's fine if you do it manually.

Cheers, James.

davidherney commented 3 years ago

Ready! Fixed in MOODLE_33 branch.

Thx @james-cnz