search

davidherney / moodle-format_onetopic

Course format Onetopic to LMS Moodle
GNU General Public License v3.0
19 stars 44 forks source link

Inherit hidden #98

Closed james-cnz closed 2 years ago

james-cnz commented 3 years ago

This is an attempt to close #83. It also makes #97 irrelevant. It's large, but I think it's fairly readable. I've done a little testing, but it probably needs more.

james-cnz commented 3 years ago

I forgot, there's still course navigation and activity navigation to deal with. As a workaround for activity navigation, it could just be hidden with CSS (not a proper fix though). Course navigation would require code.

james-cnz commented 3 years ago

Accepting this patch would depend on it being considered OK to hide activity navigation.

Also note that the CSS used for hiding activity navigation only works in Moodle >= 3.6. There's some discussion about supporting lower Moodle versions here: https://moodle.org/mod/forum/discuss.php?d=362242#p1595484

james-cnz commented 3 years ago

It just occurred to me, too, subsections of hidden sections won't be hidden in the Moodle App.