Closed sandhose closed 10 months ago
Thanks for this, and sorry for the delayed review.
Overall I'm totally fine with adding this.
Would you be willing to add some tests for this functionality, maybe using serde_path_to_error
, so that we can be sure that the pythonize
public API will continue to support your use case going forward?
Base: 80.99% // Head: 81.16% // Increases project coverage by +0.16%
:tada:
Coverage data is based on head (
6aaf26b
) compared to base (d1e629d
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
What's the status on this PR? I think it's important we get this merged!
Would you be willing to add some tests for this functionality, maybe using
serde_path_to_error
, so that we can be sure that thepythonize
public API will continue to support your use case going forward?
It's not necessary as serde_path_to_error
just requires that the (de)serializer are public and implement the relevant traits from serde
Also PythonizeDefault
isn't public, which breaks Pythonizer::new
Still waiting for tests.
It's not necessary as serde_path_to_error just requires that the (de)serializer are public and implement the relevant traits from serde
I disagree, without tests I could easily make these types not public by accident in a future release. All a test would need to do is make an example use of serde_path_to_error
. That would be sufficient to function as a guard against me removing these.
@Waelwindows, If you'd like to see this merged, perhaps you would be willing to push a copy of this PR with a test added please?
Replaced by #52
This exposes the Pythonizer and Depythonizer structs, adding documentation to them and to their public methods. It also adds methods to create a Pythonizer.
Fixes #30