Closed LilyFoote closed 1 month ago
Patch coverage: 88.88
% and project coverage change: +0.40
:tada:
Comparison is base (
cfce252
) 80.99% compared to head (858a3fb
) 81.40%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for this! This seems reasonable, though I'm also slightly cautious. What's the use case for this? I'm split down the middle on whether allowing set
/ frozenset
as inputs to rust sequences makes sense. E.g. set
/frozenset
are unordered containers, but we are converting them to an ordered type?
To be fair, serde_json
looks like it's doing the same e.g. HashSet
becomes a JSON list.
Thanks for this! This seems reasonable, though I'm also slightly cautious. What's the use case for this?
While I was trying to work out what the best way to handle my use case (see #38) I discovered that the set
and frozenset
code paths give an unexpected error. So this PR is avoiding that error in the way that fit with what the code seemed to be trying to do.
I'm split down the middle on whether allowing
set
/frozenset
as inputs to rust sequences makes sense. E.g.set
/frozenset
are unordered containers, but we are converting them to an ordered type?
Yeah - the alternatives I can think of are:
newtype_struct
(https://serde.rs/data-model.html#types).To be fair,
serde_json
looks like it's doing the same e.g.HashSet
becomes a JSON list.
Yeah, the serde docs (https://serde.rs/data-model.html#types) suggest this handling too, so it's consistent with rust stuff in general. But it does lose a bit of information, so I'm also not certain what's best.
For my use case, an error immediately with #38 or something with newtype_struct
(I'm really not sure exactly what this would look like) would probably be most useful.
Adding these tests shows the following errors: