davidhi7 / ddcci-plasmoid

KDE Plasma widget to adjust the brightness of multiple external monitors
MIT License
409 stars 12 forks source link

Add toggle power button for monitor #43

Closed hwrnr closed 1 year ago

hwrnr commented 1 year ago

Added button to enable monitor turning on/off, depending on current state. Also, showing currrent power state next to brightness.

Ignore errors from ddcutil command for not perfect ddcci installations (ddcutils first prints a lot of error lines, and then actual output on the last line)

davidhi7 commented 1 year ago

In the branch version_0.2 I am currently rewriting the backend and widget, this includes new options to turn monitors on or off. Considering this rewrite should be finished soon, I am not planning to merge your PR.

I am aware of various ddcutil error messages that need to be ignored. Feel free to share the error messages you encountered so I can include these to a ignore list in the next release.

hwrnr commented 1 year ago

This is the beginning of every ddcutil command. I have i2c_dev loaded.

Unable to open directory /sys/bus/i2c/devices/i2c--1: No such file or directory
Device /dev/i2c-255 does not exist. Error = ENOENT(2): No such file or directory
/sys/bus/i2c buses without /dev/i2c-N devices: /sys/bus/i2c/devices/i2c-255
Driver i2c_dev must be loaded or builtin
See https://www.ddcutil.com/kernel_module
...
davidhi7 commented 1 year ago

Yes this is a bug in ddcutil versions prior to 1.4.1, I'll add it to the code.