search

davidhodge931 / ggblanket

Simplify ggplot2 visualisation
https://davidhodge931.github.io/ggblanket/
Other
150 stars 8 forks source link

ness helpers are not well named #895

Closed davidhodge931 closed 3 months ago

davidhodge931 commented 3 months ago

lightness, greyness and darkness suggest colours they are not.

This is particularly weird if using aes_contrast(dark = lightness[1], ... )

An idea:

Rename lightness, greyness and darkness to:

aes_contrast(dark = light_mode_palette[1], ... )

Remove linewidthness

davidhodge931 commented 3 months ago

Another idea

mode_palette <- list(
  light = lightness,
  grey = greyness,
  dark = darkness,
)

aes_contrast(dark = mode_palette$light[1], ... )
davidhodge931 commented 3 months ago

Lists difficult for new users

Don't like naming some pals with "_palette" and some without

No better ideas.

Leave as is, and avoid breaking stuff unnecessarily