positional scales: remove `*_limits`, and `*_oob`

davidhodge931 commented 3 months ago

Remove positional *_limits, *_oob and *_expand options from API

Pro's & con's:

make a more coherent API: a symmetric axis is always built for linear scales on the relevant scale
simplify the code
for a symmetric axis, limits can be set using a vector of breaks anyway
in general, encourage users not to modify limits - and instead use *_expand_limits
users can use + scale_*_continuous(labels = scales::label_comma()) to remove symmetric scale etc
the col scale wouldn't adopt this approach, and this would make the API differ between positional and col scales

davidhodge931 commented 3 months ago

davidhodge931 commented 3 months ago

Done :)

davidhodge931 / ggblanket