search

davidhu2000 / react-spinners

A collection of loading spinner components for react
https://www.davidhu.io/react-spinners
MIT License
3.03k stars 263 forks source link

Upgrade to 0.11 fails - Module not found: Error: Can't resolve '@emotion/core' #425

Closed tonydehnke closed 2 years ago

tonydehnke commented 3 years ago

Describe the bug (Newbie here)

When dependabot ran today - it tried to upgrade react-spinners from 0.10.6 to 0.11.0.

CI testing failed with an error: Module not found: Error: Can't resolve '@emotion/core'

I googled it and found this in another repo: https://github.com/projectstorm/react-diagrams/issues/783

"Apparently in Emotion 11, @emotion/core was renamed to @emotion/react,"

It seems like maybe the dependancies for react-spinners need to be updated or changed so that the right ones are installed?

ERROR in ./app/javascript/components/EventsFormScheduler.tsx Module not found: Error: Can't resolve '@emotion/core' in '/home/circleci/project/app/javascript/components' @ ./app/javascript/components/EventsFormScheduler.tsx 20:0-36 130:9-12 @ ./app/javascript/components/EventsForm.tsx @ ./app/javascript/components/Editor.tsx @ ./app/javascript/components/Scheduler.tsx @ ./app/javascript/components/App.tsx @ ./app/javascript/packs/index.tsx

Expected Behaviour:

AwolDes commented 3 years ago

Getting a similar problem with react 17& v0.11 of spinners - https://github.com/davidhu2000/react-spinners/issues/430#issuecomment-873717462

davidhu2000 commented 3 years ago

hmm, that's strange, I don't see any reference to @emotion/core in this codebase. are you able to share some more code to help reproduce?

davidhu2000 commented 3 years ago

the PR to rename to @emotion/react https://github.com/davidhu2000/react-spinners/pull/329/files

davidhu2000 commented 2 years ago

this issue should be resolved in 0.13.0 as emotion is getting removed, see #208 and #474 for more details