search

davidhu2000 / react-spinners

A collection of loading spinner components for react
https://www.davidhu.io/react-spinners
MIT License
3.07k stars 264 forks source link

Allow for React 18 > #516

Closed bearsworth closed 2 years ago

bearsworth commented 2 years ago

Is your feature request related to a problem? Please describe. I believe this package won't work for React 18 and greater. Here is the issue:

npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.0.0 || ^17.0.0" from react-spinners@0.11.0 npm ERR! node_modules/react-spinners npm ERR! react-spinners@"^0.11.0" from the root project

Describe the solution you'd like If possible, allow for React 18, this is a great and easy to use spinner. Would love to be able to use it in newer projects.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

bearsworth commented 2 years ago

I have used --legacy-peer-deps which seems to work.

davidhu2000 commented 2 years ago

@bearsworth please update to 0.12.0 which includes react 18 support

bearsworth commented 2 years ago

@davidhu2000 Thanks for that and thanks for this awesome package man.