search

davidhu2000 / react-spinners

A collection of loading spinner components for react
https://www.davidhu.io/react-spinners
MIT License
3.07k stars 264 forks source link

Update css prop to cssOverride to avoid type conflicts #524

Closed davidhu2000 closed 2 years ago

davidhu2000 commented 2 years ago

What changes are introduced?

css is a prop used in many major css-in-js libraries like emotion and styled-components. Since the removal of emotion, using css prop can cause type conflicts.

in this package, we have

interface CommonProps {
  css?: CSSProperties;

and it is InterpolationWithTheme<any> in emtion https://github.com/emotion-js/emotion/issues/1800.

Rename should mean we avoid this conflict in repos using both this library and emotion.