davidhu2000 / react-spinners

A collection of loading spinner components for react
https://www.davidhu.io/react-spinners
MIT License
3.01k stars 261 forks source link

Pacman Loader overlaps with other content #550

Open bsgriggs opened 1 year ago

bsgriggs commented 1 year ago

Package Version 0.13.6

Describe the bug I have a caption that is supposed to be rendered underneath the pacman loader, but the pacman's head overlaps with nearby content;

To Reproduce JSX similar to the following <div id={name} className="mx-spinner"> <PacmanLoader aria-label="Loading Pacman Spinner" color={spinnerColor} speedMultiplier={speedMultiplier} size={spinnerSize} /> <span>{spinnerCaption?.value}</span> </div>

Expected behavior The bounds of the loader should push other content.

Screenshots Current: Screenshot 2022-11-01 at 10 54 01 AM

Expected: Screenshot 2022-11-01 at 10 35 02 AM

Additional context Note this can be fixed by setting Width and Height of the parent container with 2x the user's size value

cssOverride={{width: calc(${spinnerSize} * 2), height:calc(${spinnerSize} * 2)}}

bsgriggs commented 1 year ago

Same thing with Rotate, Propagate, and Sync

davidhu2000 commented 1 year ago

@bsgriggs PacmanLoader is fixed in 0.13.7 based on your recommendation, still need to look into the other 3.