search

davidhu2000 / react-spinners

A collection of loading spinner components for react
https://www.davidhu.io/react-spinners
MIT License
3k stars 260 forks source link

fix: multiple hash loader with different color renders as the same color #602

Closed davidhu2000 closed 1 week ago

davidhu2000 commented 1 week ago

What changes are introduced?

fixes #581

generate a random hash when creating animation keyframe

Any screenshots?

Screenshot 2024-06-24 at 10 47 00 AM

raviqqe commented 1 week ago

This seems to break the snapshot tests as the animation strings are injected and they are used for summary hashes of CSS classes. Can we use something else for the suffix generation like a hash function?

davidhu2000 commented 6 days ago

This seems to break the snapshot tests as the animation strings are injected and they are used for summary hashes of CSS classes. Can we use something else for the suffix generation like a hash function?

this has been reverted and published as 0.14.1. i think a hashing function make sense. using the color prop as part of the hash should solve this issue

raviqqe commented 5 days ago

Thanks for the revert!