Ensure fn4_lockmonitor does not terminate if database connectivity fails

davidhwyllie / findNeighbour4

A server delivering large scale, incrementable, bacterial relatedness monitoring

MIT License

3 stars 2 forks source link

Ensure fn4_lockmonitor does not terminate if database connectivity fails #101

Closed davidhwyllie closed 3 years ago

davidhwyllie commented 3 years ago

At present, it is possible that if database connectivity fails, fn4_lockmonitor may terminate. This may prevent fn4_lockmonitor unlocking any persistent locks which may have resulted from server crashes.

We need to set up tests to simulate database connectivity errors and ensure the fn4_lockmonitor behaves appropriately.

davidhwyllie commented 3 years ago

An alternative approach would be to use a linux specific approach (such as /etc/init.d) to ensure the process restarts if it crashes

davidhwyllie commented 3 years ago

Trapped errors in database connection components, and built unit tests ensuring these were correctly trapped

davidhwyllie commented 3 years ago

Resolved by PR #108