davidjameshowell / epicgames-freegames-heroku

claabs / epicgames-freegames-node on Heroku!
29 stars 46 forks source link

Email Error #3

Closed ridvanaltun closed 3 years ago

ridvanaltun commented 3 years ago

I updated the my fork and make Mailgun setup, after that I rerun EpicGamesFreeGamesRun action, it not worked.

Heroku Logs, (I censorship my credentials):

2020-12-22T14:32:43.617148+00:00 heroku[web.1]: Starting process with command `docker-entrypoint.sh`
2020-12-22T14:32:47.342414+00:00 app[web.1]: Warning: Using a password with '-a' or '-u' option on the command line interface may not be safe.
2020-12-22T14:32:47.371348+00:00 app[web.1]: Incoming env vars:
2020-12-22T14:32:47.377689+00:00 app[web.1]: RUN_ON_STARTUP: true
2020-12-22T14:32:47.378009+00:00 app[web.1]: CRON_SCHEDULE: 
2020-12-22T14:32:47.378058+00:00 app[web.1]: RUN_ONCE: true
2020-12-22T14:32:47.379445+00:00 app[web.1]: No JSON file found
2020-12-22T14:32:47.379663+00:00 app[web.1]: Setting config variables
2020-12-22T14:32:47.380183+00:00 app[web.1]: Run on startup: true
2020-12-22T14:32:47.380458+00:00 app[web.1]: Run once: true
2020-12-22T14:32:49.180856+00:00 app[web.1]: 
2020-12-22T14:32:49.180877+00:00 app[web.1]: > epicgames-freegames-node@3.0.0 start /usr/app
2020-12-22T14:32:49.180878+00:00 app[web.1]: > node dist/src/index.js
2020-12-22T14:32:49.180879+00:00 app[web.1]: 
2020-12-22T14:32:53.044779+00:00 heroku[web.1]: State changed from starting to up
2020-12-22T14:32:53.077607+00:00 app[web.1]: [2020-12-22 14:32:52.965 +0000] INFO  (18 on 9a3fc140-ec96-4f75-b125-396de63ec2f3): Checking free games for ridvanaltun@outlook.com
2020-12-22T14:32:53.079959+00:00 app[web.1]: [2020-12-22 14:32:53.079 +0000] INFO  (18 on 9a3fc140-ec96-4f75-b125-396de63ec2f3): Converting ./config/ridvanaltun@outlook.com-cookies.json cookie format
2020-12-22T14:32:54.629045+00:00 app[web.1]: [2020-12-22 14:32:54.627 +0000] ERROR (18 on 9a3fc140-ec96-4f75-b125-396de63ec2f3): Error sending email. Please check your configuration
2020-12-22T14:32:54.629058+00:00 app[web.1]:     emailConfig: {
2020-12-22T14:32:54.629059+00:00 app[web.1]:       "smtpHost": "smtp.mailgun.org",
2020-12-22T14:32:54.629060+00:00 app[web.1]:       "smtpPort": 587,
2020-12-22T14:32:54.629061+00:00 app[web.1]:       "emailSenderAddress": "postmaster@xxxxxxxxxxxxxxxxx.mailgun.org",
2020-12-22T14:32:54.629063+00:00 app[web.1]:       "emailSenderName": "[epic-games] Epic Games Free Captcha",
2020-12-22T14:32:54.629064+00:00 app[web.1]:       "emailRecipientAddress": "ridvanaltun@outlook.com",
2020-12-22T14:32:54.629065+00:00 app[web.1]:       "secure": true,
2020-12-22T14:32:54.629066+00:00 app[web.1]:       "auth": {
2020-12-22T14:32:54.629067+00:00 app[web.1]:         "user": "postmaster@xxxxxxxxxxxxxxxxx.mailgun.org",
2020-12-22T14:32:54.629067+00:00 app[web.1]:         "pass": "xxxxxxxxxxxxxxxxx"
2020-12-22T14:32:54.629068+00:00 app[web.1]:       }
2020-12-22T14:32:54.629068+00:00 app[web.1]:     }
2020-12-22T14:32:54.630954+00:00 app[web.1]: [2020-12-22 14:32:54.628 +0000] ERROR (18 on 9a3fc140-ec96-4f75-b125-396de63ec2f3): 140647282953544:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:
2020-12-22T14:32:54.630955+00:00 app[web.1]: 
2020-12-22T14:32:54.630956+00:00 app[web.1]:     Error: 140647282953544:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:
2020-12-22T14:32:54.630957+00:00 app[web.1]:     
2020-12-22T14:32:54.631307+00:00 app[web.1]: [2020-12-22 14:32:54.630 +0000] ERROR (18 on 9a3fc140-ec96-4f75-b125-396de63ec2f3): 140647282953544:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:
2020-12-22T14:32:54.631308+00:00 app[web.1]: 
2020-12-22T14:32:54.631309+00:00 app[web.1]:     Error: 140647282953544:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:332:
2020-12-22T14:32:54.631309+00:00 app[web.1]:     
2020-12-22T14:32:54.674790+00:00 app[web.1]: Exiting...
2020-12-22T14:32:54.678686+00:00 app[web.1]: Warning: Using a password with '-a' or '-u' option on the command line interface may not be safe.
2020-12-22T14:32:54.683762+00:00 app[web.1]: OK
2020-12-22T14:32:54.814006+00:00 heroku[web.1]: Process exited with status 0
2020-12-22T14:32:54.869366+00:00 heroku[web.1]: State changed from up to crashed

In this 2020-12-22T14:32:54.629045+00:00 line the error started.

davidjameshowell commented 3 years ago

Please check your SMTP settings to use port 465 and to use SMTP_SECURE set to true. in your Heroku environmental variables.

ridvanaltun commented 3 years ago

Please check your SMTP settings to use port 465 and to use SMTP_SECURE set to true. in your Heroku environmental variables.

Thanks, everything works now.

I was manually update my fork so i didn't update using EpicGamesFreeGamesUpdate action, after hitting to EpicGamesFreeGamesUpdate action, It didn't change my environment variables, I assume it directly pass by looking last commit. A notice that says manual update may break your deployment would be great in readme file.

davidjameshowell commented 3 years ago

Please check your SMTP settings to use port 465 and to use SMTP_SECURE set to true. in your Heroku environmental variables.

Thanks, everything works now.

I was manually update my fork so i didn't update using EpicGamesFreeGamesUpdate action, after hitting to EpicGamesFreeGamesUpdate action, It didn't change my environment variables, I assume it directly pass by looking last commit. A notice that says manual update may break your deployment would be great in readme file.

Ah - yes. I see; since it only runs on deployment. Might it be helpful if the update function includes the env vars as well in order to ensure and updates are backwards compatible?

ridvanaltun commented 3 years ago

Please check your SMTP settings to use port 465 and to use SMTP_SECURE set to true. in your Heroku environmental variables.

Thanks, everything works now. I was manually update my fork so i didn't update using EpicGamesFreeGamesUpdate action, after hitting to EpicGamesFreeGamesUpdate action, It didn't change my environment variables, I assume it directly pass by looking last commit. A notice that says manual update may break your deployment would be great in readme file.

Ah - yes. I see; since it only runs on deployment. Might it be helpful if the update function includes the env vars as well in order to ensure and updates are backwards compatible?

Checking a variable before update seems to me a best practice to ensure backwards compatibility. So, why not 👍

davidjameshowell commented 3 years ago

OK, I moved the env var set to update, so any updates to the image process should reset any missing (or pulled in) variables.