search

davidjameshowell / vaultwarden_heroku

Vaultwarden (Bitwarden Rust implementation) self hosted in Heroku for Free!
96 stars 176 forks source link

Remove unnecessary email parameter #10

Closed bryanjhv closed 3 years ago

bryanjhv commented 3 years ago

After checking out Heroku documentation, and some old GitHub action, I discovered that it's not necessary to set the email address for Heroku CLI as long as you set the HEROKU_API_KEY environment variable.

The first link also tells that .netrc is useful when using Heroku's HTTP Git service, which your script doesn't use (because it just pushes to container registry), so it's safe to also remove that step from the build (maybe while avoiding side effects).

I have tested this on GitHub Actions environment, and it works, as you can see: (the commit hashes match with the one from this pull request)

https://github.com/bryanjhv/bitwarden_rs_heroku/actions/runs/587779699

davidjameshowell commented 3 years ago

Great PR! Looks good to me. This will help simplify things as well!