search

davidjbradshaw / iframe-resizer

Keep iFrames sized to their content.
https://iframe-resizer.com
Other
6.63k stars 978 forks source link

BREAKING🐞: `v4.3.9` release breaks usage of `.min.js` file from CDN #1195

Closed xsjcTony closed 2 months ago

xsjcTony commented 8 months ago

After v4.3.9, the .min.js file is no longer part of the dist files, hence https://unpkg.com/iframe-resizer/js/iframeResizer.contentWindow.min.js is not working anymore.

For any of my websites using this file, they are all broken. For now, I have to do a PROD release to replace it with https://unpkg.com/iframe-resizer/js/iframeResizer.contentWindow.js but I do think if user has the option to use the minified version could be better

Breaking change: https://github.com/davidjbradshaw/iframe-resizer/commit/b3d5eba851dd20e93d70708ff197851b6c4aa82e#diff-34958b02363eec9a904716f0b4a8782b021c6b33b2e8599019e36c88e045240bR8

xsjcTony commented 8 months ago

And the thing is I don't really get what's the benefit to remove .min.js file? Removing .map makes sense but .min.js file should be needed. The whole v4.3.9 update doesn't make any sense to me.

And I don't see any improvements there:

https://bundlephobia.com/package/iframe-resizer@4.3.8 https://bundlephobia.com/package/iframe-resizer@4.3.9

So basically, for bundler users, no package size changed at all. For CDN users, .min.js usage just broke straight away.

colinrotherham commented 8 months ago

Thanks again for your hard work on this project

Same issue for us but without a CDN, as we include iframeResizer.contentWindow.min.js via <script>

Our Dependabot PR caught the deleted file but others might miss the change without a v5.0.0 release

wfehr commented 6 months ago

Any updates or estimates if or when to expect this to be fixed?

janpapenbrock commented 3 months ago

Looks like this may have been fixed with https://github.com/davidjbradshaw/iframe-resizer/commit/a3582f6ef33b5a6f9ec9649375a8176c72d77b7a in 4.3.10

https://unpkg.com/iframe-resizer/js/iframeResizer.contentWindow.min.js is working again and resolves to https://unpkg.com/iframe-resizer@4.3.10/js/iframeResizer.contentWindow.min.js

davidjbradshaw commented 2 months ago

Yep, sorry forgot to update.