Closed JoshuaCrewe closed 2 years ago
Attempts to address #292
@JoshuaCrewe thanks a bunch ππ». Iβll change the setup so you only have to run yarn install
and yarn start
in the future, in order to start a local dev server with the documentation website. Right now you have to run yarn workspace embla-carousel-docs run start
to get it going.
Iβll merge this soon. Again, thanks!
So I don't use yarn
any more. I did install it especially but when I did yarn install
I got literally hundred of error messages. I have never come accross yarn workspace
before. Will read up on that one.
When I have more time I am willing to give it more of a go!
@JoshuaCrewe would you mind rebasing your changes on the master branch? I tried but it was rejected. I donβt think I have the permissions to do anything on your fork.
Absolutely. It is Saturday today which means shabbat wins out. There will be a short delay until I am back at my computer (just FYI) π
@JoshuaCrewe haha no rush! Take your time. Iβm just happy you want to contribute ππ».
If I did it right, then the latest from your master
has been rebased on this PR. Let me know if this is not what you were after!
@JoshuaCrewe the rebase was successful. Welcome to the contributors club π. Feel free to contribute again, it's very much appreciated. Thank you π!
:tada: :tada: :tada:
For the record, you did 90% of the work. I am very happy to have pushed the 10% :blush:
When following along with the Get Started guide, the example CSS doesn't allow autoheight to work properly. The flex container will set all the slides to be the same height making the autoheight script useless. Adding some direction to the docs to amend the example CSS will help avoid this issue.
I couldn't get gatsby to build the site so this PR is blind I am afraid. Seeing as the suggestion is a minor one, I didn't foresee this being a major issue. Feel free to insist, it will be a bit of a gap before I can update the PR in that case.
Feedback, criticism and amend requests welcome.