search

davidjerleke / embla-carousel

A lightweight carousel library with fluid motion and great swipe precision.
https://www.embla-carousel.com
MIT License
5.49k stars 167 forks source link

Support for solid-js #429

Closed oSethoum closed 6 months ago

oSethoum commented 1 year ago

Can you support solid-js which has been gaining a lot of interest lately.

davidjerleke commented 1 year ago

Hi @oSethoum,

Thanks for your question. Let’s see if SolidJs devs are interested in this.

React with a —> 👍 if you want this feature.

BoilingSoup commented 1 year ago

Hi just wanted to share that I was able to get Embla working very easily with Solid by following the vanilla JS steps.

Only thing I did different was add the JS code inside Solid's onMount() callback. Plugins are working perfectly too.

Here's a small demo: https://stackblitz.com/edit/solidjs-templates-qznzud?file=src/App.tsx

davidjerleke commented 6 months ago

Merged thanks to @LiamMartens great contribution. embla-carousel-solid will be released with v8.0.0-rc19 soon 🎉 !

davidjerleke commented 6 months ago

@oSethoum, @aquaductape, @frozar, @ronaldruzicka, @Kies8, @ruijdacd, @RichardSPrins, @BoilingSoup, @flamrdevs, @StitiFatah, @jordant97, @dennisregalado, @alexnguyennz, @mikehwagz, @jamielaw-jellyfish, @its-monotype, @zaitsev1, @tobimori, @kielerdotdev, @ZorikovPasha, @itome, @VincentWENDLING, @dash-james, @pokedotdev, @ploskovytskyy, @jassix, @chemagares.

I just released the SolidJs wrapper with v8.0.0-rc19. Thanks a ton @LiamMartens ⭐!

Here's the get started guide.

There's still a lot to do. We need to add SolidJs code examples under all API pages. For example, here. Feel free to add these if you want to contribute.

Best, David