search

davidjerleke / embla-carousel

A lightweight carousel library with fluid motion and great swipe precision.
https://www.embla-carousel.com
MIT License
6.01k stars 180 forks source link

Add example for Nested carousels with new `watchDrag` feature to docs #468

Closed tobimori closed 1 year ago

tobimori commented 1 year ago

Feature request is related to

Is your feature request related to an issue?

With the new watchDrag feature it's very easy to build nested carousels. I just spent 3 hours fiddling with the CodeSandbox linked in #141 until I stumbled upon that new release with magically fixed all my problems with e.g. looped slides.

Describe the solution you'd like

Have a clear example for nested carousels in the docs. <3

davidjerleke commented 1 year ago

Hi @tobimori,

Feel free to create an example using watchDrag and share here. I'm working on v8 and a new tool so any help that offloads work and frees up time is appreciated. You can fork one of the existing examples if you that's easier for you and I will migrate your sandbox to the docs when it's done.

Best, David

mi-na-bot commented 1 year ago

I was browsing the issues to see if there was any discussion of adding nested carousel support, but this is even better!

@tobimori Are you interested in making a PR? If not, do you have a sandbox where it works with the new feature I could look through to make an example?

tobimori commented 1 year ago

I probably don't have the time to provide a PR in the near future, but I can provide you with a snippet of my slider.

https://gist.github.com/tobimori/770dcfb16c76caf61eecf39252b62997 You can find it here, at the end: https://pitchguru.com/beispiele

Feel free to take over any code from that for creating an example 🙌

davidjerleke commented 1 year ago

@minervabot or @tobimori are any of you guys planning to create an example or should I close this issue for now?