davidjerleke / embla-carousel

A lightweight carousel library with fluid motion and great swipe precision.
https://www.embla-carousel.com
MIT License
5.42k stars 164 forks source link

Carousel isn't reactivating after resizing from a breakpoint with `active: false` #486

Closed turtlecrab closed 1 year ago

turtlecrab commented 1 year ago

Bug is related to

Embla Carousel version

Describe the bug

CodeSandbox

Steps to reproduce

  1. In the sandbox make sure that the width of the built-in browser is <600, if it's not - resize and refresh it
  2. Check that the carousel is working as expected
  3. Resize built-in browser so the width is > 600, check that the carousel stopped working
  4. Resize it back
  5. Observe that the carousel isn't working
  6. (optional) Change the version from 8.0.0-rc05 to 7.1.0 and repeat all the steps, observe that it's working as expected

Expected behavior

davidjerleke commented 1 year ago

Hi @turtlecrab,

Thank you for this crystal clear bug report. I can confirm that this is a bug. I will ship a fix for this in v8.0.0-rc06 as soon as possible. Stay tuned.

Best, David

davidjerleke commented 1 year ago

@turtlecrab try this sandbox and see if that solves the problem. Let me know how it goes.

Best, David

turtlecrab commented 1 year ago

@davidjerleke works fine on my side. Thank you for blazing fast fix!

davidjerleke commented 1 year ago

Released with v8.0.0-rc06. Thanks for this clear and well written bug report @turtlecrab!