After running for a while 'cannot read properties of undefined' error is thrown

jjachowski commented 11 months ago

Bug is related to

[x] embla-carousel (core package)

Embla Carousel version

embla-carousel-react: 8.0.0-rc11
embla-carousel-autoplay": 8.0.0-rc11

Describe the bug

After leaving carousel with autoplay plugin for a longer while (up to 30 minutes) 'cannot read properties of undefined' error is thrown.
Setting autplay plugin options delay: 1 instantly reproduces bug

CodeSandbox

The link to a CodeSandbox that demonstrates the bug clearly.
embla generator was used to generate this example, with options: React + Typescript, horizontal, left to right, loop, slide size 100, slide gaps 10, center, previous and next buttons, dot navigation, autoplay plugin.

Steps to reproduce

Open link in the browser
Wait
Error should be thrown after longer while
Can be reproduced instantly by setting delay: 1 to autoplay options

Expected behavior

Type Error shown on screenshot should not appear after leaving carousel on autoplay

Additional context

It can take long time to see this bug, last time I tried to recreate it, it took me over 30 minutes. You can leave browser window in the background.
From my understanding undefined value is being passed to normalizeInput function. Then in ternary operator we try to .get() on this undefined value.

davidjerleke commented 11 months ago

Hi @jjachowski,

Thank you very much for a complete bug report. I’ll investigate this when possible.

Best, David

hmartiins commented 11 months ago

Hi! I would like to give feedback that this error has already appeared in the error monitoring of my site as well, but we did not have time to stop to investigate to conclude that it was the embla that was logging this error.

davidjerleke commented 11 months ago

@jjachowski please try this CodeSandbox and see if the problem is solved there.

Thanks in advance.

Best, David

jjachowski commented 11 months ago

@davidjerleke sorry for not replying sooner, must have missed notification. Looks great, thank you very much for that fix :)

davidjerleke commented 11 months ago

@hmartiins. @jjachowski thanks for confirming 👍. This bug fix will be released with v8.0.0-rc12.

Cheers, David

davidjerleke commented 10 months ago

@hmartiins, @jjachowski, a bug fix for this has been released with v8.0.0-rc12.

davidjerleke / embla-carousel