[Bug]: embla-carousel-autoplay - stopOnMouseEnter NOT WORKING on mouse enter, but only when you click inside the wrapper.

davidjerleke / embla-carousel

A lightweight carousel library with fluid motion and great swipe precision.

https://www.embla-carousel.com

MIT License

5.94k stars 180 forks source link

[Bug]: embla-carousel-autoplay - stopOnMouseEnter NOT WORKING on mouse enter, but only when you click inside the wrapper. #724

Closed shaaandi closed 8 months ago

shaaandi commented 8 months ago

Version

8.0.0-rc21

CodeSandbox

https://codesandbox.io/p/sandbox/embla-carousel-autoplay-react-forked-fsj2d2?file=%2Fsrc%2Fjs%2FEmblaCarousel.jsx%3A2%2C31-2%2C51

What browsers are you seeing the problem on?

Chrome

Steps to reproduce

the feature is simply not working for the autoplay plugin

Expected Behavior

It should work as the naming said.

Additional Context

it is working in the 7.1.0 version

Which variants of Embla Carousel are you using?

[X] embla-carousel (Core)
[X] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[X] embla-carousel-autoplay
[ ] embla-carousel-solid
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

davidjerleke commented 8 months ago

@shaaandi I can't access your sandbox:

shaaandi commented 8 months ago

@davidjerleke mb. https://codesandbox.io/p/sandbox/embla-carousel-autoplay-react-forked-fsj2d2

davidjerleke commented 8 months ago

Thanks @shaaandi.

If I'm to guess, you're trying to achieve some sort of continuous scroll with the Autoplay plugin. Is that correct?

Here, it doesn't make sense to set duration to 2000. The docs has a clear note about what values are recommended, which is any value between 20 - 60.
And here, delay: 1 doesn't make sense at all for a timer based Autoplay plugin. It's called a timer because it's supposed to run in intervals, not once every millisecond.
When using values that makes sense, stopOnMouseEnter is working just as expected.

If you want to achieve a continuous auto scroll effect, I think you're looking for the Auto Scroll plugin instead, which is available from v8.0.0-rc22 and up.

Best, David

shaaandi commented 8 months ago

@davidjerleke

Thanks for the fast response. I am going to use the auto scroll then. Thanks.