search

davidjerleke / embla-carousel

A lightweight carousel library with fluid motion and great swipe precision.
https://www.embla-carousel.com
MIT License
5.37k stars 164 forks source link

[Feat]: Add RTL case for slide gaps via CSS in docs #786

Closed zaaakher closed 2 months ago

zaaakher commented 3 months ago

Hi @davidjerleke,

Hope you're doing well.

This PR is a simple addition to the slide-gaps section of the docs to mention the RTL case.

Let me know If I missed something

Best, Zakher

zaaakher commented 3 months ago

Note: formatting that file via prettier kept adding an extra backtick as seen on line 50

davidjerleke commented 3 months ago

@zaaakher nice to have you back 🙂. Thanks for the contribution. I will review as soon as I get a chance.

Best, David

zaaakher commented 3 months ago

I made the changes of this PR "blindfolded" (without running the docs gatsby app due to https://github.com/davidjerleke/embla-carousel/issues/662). So my apologies for missing tiny things here or there 😅

davidjerleke commented 3 months ago

I made the changes of this PR "blindfolded" (without running the docs gatsby app due to #662). So my apologies for missing tiny things here or there 😅

@zaaakher no worries. I’m thankful that you continuously want to make this library better! Thanks for the fixes. I’m ready to merge this as soon as I’ve squashed the commits 🎉.

zaaakher commented 3 months ago

@zaaakher no worries. I’m thankful that you continuously want to make this library better! Thanks for the fixes. I’m ready to merge this as soon as I’ve squashed the commits 🎉.

You're welcome brother, it's my absolute pleasure. 🌹

davidjerleke commented 2 months ago

Released in v8.0.1.