search

davidjkrause / sportsipy

A free sports API written for python
MIT License
31 stars 8 forks source link

NBA - Wins Losses Games Played, etc. #5

Closed cfox570 closed 9 months ago

cfox570 commented 9 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] I am looking for WINS LOSES GAMES PLAYED that are missing from NBA stats but present in NFL, MLB, NCAAB.

Describe the solution you'd like A clear and concise description of what you want to happen.

Add these elements to constants and other files as appropriate. 'games_played': 'td[data-stat="g"]:first', 'wins': 'td[data-stat="wins"]:first', 'losses': 'td[data-stat="losses"]:first', 'win_percentage': 'td[data-stat="win_loss_pct"]:first',

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. Retrieving the data from games will require too many web requests.

Additional context Add any other context or screenshots about the feature request here.

davidjkrause commented 9 months ago

Please try out the updated master branch, the missing requested fields were added and tested.

Note that games_played was already available, so wins / losses / win_percentage were added.

cfox570 commented 9 months ago

Wow! Works great. Thanks for the quick update.

On Dec 28, 2023, at 1:44 PM, David Krause @.***> wrote:

Please try out the updated master branch, the missing requested fields were added and tested.

— Reply to this email directly, view it on GitHub https://github.com/davidjkrause/sportsipy/issues/5#issuecomment-1871410666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADERRZEP5NVEBI7T2DNY3TYLW4YNAVCNFSM6AAAAABBFWJQNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRGQYTANRWGY. You are receiving this because you authored the thread.