search

davidjnelson / angular-table

An angular directive for a table with fixed, sortable headers, row selection, row even/odd coloring, which automatically stays the correct height relative to its container when the browser is resized. No javascript code required; the api is a 100% declarative dsl.
http://angulartable.com
174 stars 30 forks source link

Row with Buttons #32

Open johntom opened 11 years ago

johntom commented 11 years ago

Hi, I'm trying to add a command column with 3 buttons (new,edit and delete). The following plunker illustrates the ng-click problem as the only the a href="http://www.gtz.com" works. http://plnkr.co/edit/SKdu8sFRFOt6qg1J1o0n?p=preview TIA John

mlaccetti commented 10 years ago

@johntom - you need to prefix your edit and del functions with 'parent.' - http://plnkr.co/edit/wV8GJOvy37aGdjnlMhuH?p=preview

johntom commented 10 years ago

Hi Michael,

Unless I'm missing something the edit and del button click event still does not fire. Only the following event works.

<row on-selected="handleRowSelection(row)" ....>

Thanks

John

From: Michael Laccetti [mailto:notifications@github.com] Sent: Tuesday, December 10, 2013 11:08 PM To: davidjnelson/angular-table Cc: John R. Tomaselli Subject: Re: [angular-table] Row with Buttons (#32)

@johntom https://github.com/johntom - you need to prefix your edit and del functions with 'parent.' - http://plnkr.co/edit/wV8GJOvy37aGdjnlMhuH?p=preview

— Reply to this email directly or view it on GitHub https://github.com/davidjnelson/angular-table/issues/32#issuecomment-30292517 . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif

No virus found in this message. Checked by AVG - www.avg.com Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13

mlaccetti commented 10 years ago

Not too sure what's going on - I clicked 'edit' on a row, and the form on the right had the data populated. Here's a quick screenshot:

screenshot

johntom commented 10 years ago

Hi Michael,

The code always worked like that because of

Notice that edit and del buttons are designed to raise an alert.

John

From: Michael Laccetti [mailto:notifications@github.com] Sent: Wednesday, December 11, 2013 2:50 PM To: davidjnelson/angular-table Cc: John R. Tomaselli Subject: Re: [angular-table] Row with Buttons (#32)

Not too sure what's going on - I clicked 'edit' on a row, and the form on the right had the data populated. Here's a quick screenshot:

screenshot https://github-camo.global.ssl.fastly.net/b6745f8e4fb9c5fd3e8abb716f33094e8516d674/687474703a2f2f692e696d6775722e636f6d2f3361734475564d2e706e67

— Reply to this email directly or view it on GitHub https://github.com/davidjnelson/angular-table/issues/32#issuecomment-30356584 . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif

No virus found in this message. Checked by AVG - www.avg.com Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13

mlaccetti commented 10 years ago

Looks like you were just using an outdated version of the angularTable.js - I replaced the content with the current one from the repo and it looks good:

image

johntom commented 10 years ago

Cool. I'll check it out tomorrow and get back to you.

J

From: Michael Laccetti [mailto:notifications@github.com] Sent: Wednesday, December 11, 2013 5:22 PM To: davidjnelson/angular-table Cc: John R. Tomaselli Subject: Re: [angular-table] Row with Buttons (#32)

Looks like you were just using an outdated version of the angularTable.js - I replaced the content with the current one from the repo and it looks good:

image https://f.cloud.github.com/assets/135857/1728637/91a498dc-62b2-11e3-85d1-86ac0addda8e.png

— Reply to this email directly or view it on GitHub https://github.com/davidjnelson/angular-table/issues/32#issuecomment-30370417 . https://github.com/notifications/beacon/j9yi2VKYyNfuAJMDa9D7nMwV66TKwwVQFc80-rKkKCPpLyiAMTopxyMY4hUuNoqq.gif

No virus found in this message. Checked by AVG - www.avg.com Version: 2014.0.4259 / Virus Database: 3658/6893 - Release Date: 12/05/13