search

davidjnelson / angular-table

An angular directive for a table with fixed, sortable headers, row selection, row even/odd coloring, which automatically stays the correct height relative to its container when the browser is resized. No javascript code required; the api is a 100% declarative dsl.
http://angulartable.com
174 stars 30 forks source link

header renders improperly in firefox #33

Open davidjnelson opened 11 years ago

davidjnelson commented 11 years ago

the header on http://angulartable.com/demo/index.html renders improperly in Firefox 23.0.1 but correctly in Chrome. Specifically, the header extends out over the scrollbar and the column lines no longer line up with the table body. Is this issue fixed as part of these new updates? I didn't want to open up a whole new Issue if you already knew about it / were working on it.

msakrejda commented 11 years ago

I can confirm. I'm seeing the same thing in Firefox 24, but no problems in Chrome.

davidjnelson commented 11 years ago

Thanks Maciek,

This is an important bug to fix, I agree.

koen-serry commented 10 years ago

Wouldn't merging the 2 tables fix it and at the same time make it easier?

davidjnelson commented 10 years ago

Hi @koen-serry , how would you do that and still adjust the width of the header when enough data appeared in the table that the scrollbar appeared?

koen-serry commented 10 years ago

I'm not sure I got your question 100%, but if you're talking about the data being longer than the headers: there is no magic bullet there I guess, you either truncate, use an ellipsis or just let the header grow. But at least gui wise it would always be consistent and the choice would be given to the developer.

davidjnelson commented 10 years ago

Hi @koen-serry No, I'm referring to when an angular-table has 10 rows, and then adding an 11th row causes the vertical scrollbar to appear.