ReactOS package-related issues

[davidjoffe]

Firstly, just came across this and wanted to add it here, as cool to see:

https://github.com/reactos/rapps-db/commit/745bc9f5181ff53da254e8f1b3d93a01bbcb804d

Secondly, since ReactOS support seems to be occasionally an 'on again, off again' type of thing (it used to work but the latest seems to have some small issues - obviously it's a platform in progress, and our dependencies etc. have changed too with LibSDL2 etc.), so I thought I'd create a dedicated "Issue" here to just reporting and tracking of and helpikng solve ReactOS-compatibility-related issues, for anyone interested ...

@qbancoffee

[davidjoffe]

Quoting myself from that thread: https://github.com/reactos/rapps-db/commit/745bc9f5181ff53da254e8f1b3d93a01bbcb804d

Though I only had a few minutes to spare I quickly tried it in the latest ReactOS 0.4.14 but unfortunately the bundled package manager Dave Gnukem ~v1.0.1 (I think it was) gave an error suggesting the bundled package failed some sort of integrity check.

Then I tried our latest Windows installer 1.0.3 for Dave Gnukem (from SourceForge https://sourceforge.net/projects/gnukem/files/latest/download) but got this DLL error when trying to run it:

"The procedure entry point ucrtbase.terminate could not be located in the dynamic link library api-ms-win-crt-runtime-l1-1-0.dll"

But the good news is installing a "vc_redist.x86.exe" (in my case "MS Visual C++ 2015 Redistributable (x86)" labelled v14.0.23026 when I tested) seems to solve it :)

https://download.microsoft.com/download/9/3/F/93FCF1E7-E6A4-478B-96E7-D4B285925B00/vc_redist.x86.exe

I think the official link for that may be:

https://www.microsoft.com/en-US/Download/confirmation.aspx?id=48145

I don't have time to look into this at all right now unfortunately, so not sure yet if it's something we could or should solve by e.g. adding some 'missing' DLLs or extra step or something to our installer (possibly, I just don't have time to look right now), (or even just adding instructions to download and install this) but in the meantime users can hopefully work around it with above.

[qbancoffee]

Oh great, thanks for the info. I'll test, update and eventually do a pull request. Thank you for the game!

[davidjoffe]

So curently it works on ReactOS but seems to need that vc_redist manually installed or it gives some DLL error - but what I'm not sure of is whether the same applies even to, say, certain old versions of Windows (e.g. would it work on old Win7 clean installation 'out the box' or also need that redist? E.g. is it a "ReactOS issue" per se or just what qualifies as a packaging issue for DG, e.g. if it's just a case there's a few DLLs we should add to the installer we should do that but I'm not sure which ones, would have to look when I have time (I don't right now) but the right time to check may be when DG 1.0.4 is released, time permitting, if it's something 'quick and simple' that can be added to the DG installer (eg if it's just a couple of MSVC runtime DLLs or something) then it's worthwhile