davidjrh
commented
5 years ago Hi @andrewqit for notifying this. Checking the code, I see that the code fix I made to solve the old issue is still on the master branch https://github.com/davidjrh/dnn.azureadprovider/blob/master/DotNetNuke.Authentication.Azure/Login.ascx.cs#L80
So after downloading the 3.1.0 package and decompiling the assembly, I see that the compiled code is effectively looking like the old version. I'm not sure of how that happened (did I upload the build from another branch?)
private void loginButton_Click(object sender, EventArgs e)
{
if (string.IsNullOrEmpty(base.Request["error"]))
{
if ((!base.get_OAuthClient().IsCurrentService() ? true : !base.get_OAuthClient().HaveVerificationCode()) && base.get_OAuthClient().Authorize() == null)
{
Skin.AddModuleMessage(this, Localization.GetString("PrivateConfirmationMessage", Localization.get_SharedResourceFile()), 1);
}
return;
}
string str = Localization.GetString("LoginError", base.get_LocalResourceFile());
str = string.Format(str, base.Request["error"], base.Request["error_description"]);
this._logger.Error(str);
Skin.AddModuleMessage(this, str, 2);
}Going to check tomorrow and update the latest package.
andrewqit
The below issue from the previous version has returned with the latest version:
Fixed double exchange code for token calls, causing a login issue introduced on Azure AD after October 10th, 2018
I verified this by getting the error caused by the issue using the latest version. I then installed the previous version, and the issue was gone.