search

davidjrh / dnn.azureadprovider

The DNN Azure Active Directory Provider is an Authentication provider for DNN Platform (formerly DotNetNuke) that uses Azure Active Directory OAuth2 authentication to authenticate users.
MIT License
35 stars 21 forks source link

Saving Secrets While Not Logged In #23

Closed SkyeHoefling closed 4 years ago

SkyeHoefling commented 4 years ago

Scenario

As a host user I have logged in and opened the Persona Bar Module to configure Azure AD. My session expires and I attempt a save and no error appears.

Reproduction Steps

  1. Install Module into new instance of DNN
  2. Configure Azure AD correctly per the documentation
  3. open a new tab
  4. log out and verify that you are logged out in new tab
  5. in the original tab update the Azure AD secrets/appid or directory id

Expected Behavior

Actual Behavior

Notes/Comments

It appears this works as designed, but the front-end of the Persona Bar module doesn't get a good communication with the backend, which makes sense you are no longer logged in and the session has expired.

It would be a nice polish to add an error message on the Persona Bar module if the front-end code can't communicate with the API

Versions

DNN: 9.4.1 Module: 3.1.0

Other

This module is really great! I built custom Azure AD Providers for customers before and I was very impressed this just worked out of the box. I am really glad I found this and you guys did a great job from the UI/UX. Any Admin that is familiar with the Azure AD side shouldn't have a problem configuring this.

Great Job!

davidjrh commented 4 years ago

Thanks @ahoefling, this situation should be handled on the personaBar React component. I have added it to the backlog.

gbulicanu commented 4 years ago

@davidjrh please have a look