davidjrh / dnn.azureadprovider

The DNN Azure Active Directory Provider is an Authentication provider for DNN Platform (formerly DotNetNuke) that uses Azure Active Directory OAuth2 authentication to authenticate users.
MIT License
34 stars 21 forks source link

Question: Does this module work with the PKCE flow #62

Open Rodien opened 1 year ago

Rodien commented 1 year ago

Hi David,

Does this module work with the PKCE flow?

Have you tried this before?

davidjrh commented 1 year ago

Hi @Rodien,

Not currently, but seems that would be easy to add support by specifying the code_chanllenge parameters described at https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#request-an-authorization-code when requesting an authorization code, that should be added after this line https://github.com/davidjrh/dnn.azureadprovider/blob/master/DotNetNuke.Authentication.Azure/Components/AzureClient.cs#L625

image

Do you feel comfortable of implementing the modification and doing a PR?