search

davidjrh / dnn.azureadprovider

The DNN Azure Active Directory Provider is an Authentication provider for DNN Platform (formerly DotNetNuke) that uses Azure Active Directory OAuth2 authentication to authenticate users.
MIT License
35 stars 22 forks source link

node_modules directory included in _Install.zip package #92

Closed RichFinn-WTW closed 1 year ago

RichFinn-WTW commented 1 year ago

Hi - I noticed that your node_modules directory from the react app is being included in the install package and being output at \DesktopModules\AuthenticationServices\Azure\AzureAD.Web

image

This is adding 1.2MB of unpacked files to the host. I'm thinking it's because of this line in .build/ModulePackage.targets:22:

<InstallInclude Include="**\*.txt;**\*.ascx;**\*.css"  Exclude="**\obj\**;**\_ReSharper*\**;packages\**;" />

I also noticed that the packages directory is being included, even though it looks like you want it to be excluded in the line above.

image

Changing to the following might help:

<InstallInclude Include="**\*.txt;**\*.ascx;**\*.css"  Exclude="**\obj\**;**\_ReSharper*\**;**\packages\**;**\node_modules\**;" />
davidjrh commented 1 year ago

Thanks for reporting it! @alendv fixed it on #101