search

davidjrice / prezto_powerline

Powerline-esque theme for Prezto ZSH
117 stars 31 forks source link

Separator characters #1

Open Anrock opened 10 years ago

Anrock commented 10 years ago

Hi, just moved from oh my zsh to prezto and installed your theme. Well, there same issue with separator characters like in powerline\agnoster and similar themes from oh my zsh - arrow symbols aren't displayed correctly. Fortunately this theme could be fixed just like others: by replacing separator characters with \ue0b0 for left and \ue0b2 for right separator.

Also, a little question\feature request: could the blocks for branch and commit hash be disabled for directories that aren't under git control?

davidjrice commented 10 years ago

Tried the suggestion of changes the character codes. Those aren't working for me on OSX 10.9.4 what OS are you seeing the display issues on?

That would be a good feature indeed.

Anrock commented 10 years ago

It's 10.9.4 with iTerm2. Didn't tried it on standard terminal app.

Anrock commented 10 years ago

Also, same issue on linux machine on termite 7, lxterminal 0.1.11 and xfce4-terminal 0.6.3.

davidjrice commented 10 years ago

What about the font used in iTerm? Can't replicate.

Perhaps a before / after screenshot.

Anrock commented 10 years ago

iTerm2, antialised "12pt DejaVu Sans Mono for Powerline" as regular font and antialised "11pt DejaVu Sans Mono for Powerline" as Non-ASCII font. Both from this repo: https://github.com/Lokaltog/powerline-fonts

Here screen before fix: http://rghost.net/57017498 And after fix: http://rghost.net/57017516

davidjrice commented 10 years ago

Looks fine for me with that font too. What is your Character Encoding set to in iTerm? I was able to kindof replicate this by changing it to something other than UTF-8

Anrock commented 10 years ago

Character encoding is UTF-8. Locale is russian, though.

TheZoc commented 10 years ago

Hello,

I submitted a patch (Issue #2) that has this fix. According to Powerline documentation, the codes changed:

Warning

The code points have changed in this version of Powerline! This means that you either have to patch your font again, or change the glyphs Powerline uses in your user configuration.

And

Now it says that

Powerline stores all special glyphs in the Unicode Private Use Area (U+E000-U+F8FF).

I hope it helps! :D

Anrock commented 10 years ago

@TheZoc nice, thanks. @davidjrice there is a fix already, so i guess it's fine to close this issue as fix'd.

ericbn commented 8 years ago

This was fixed by pull req #2, that was merged already.

TheZoc commented 8 years ago

And it only took 2 years to get merged! :)