search

davidjtferguson / dancejab

super simple fighting game. dashing and jabbing only.
MIT License
3 stars 0 forks source link

kept playing after win bug #35

Closed davidjtferguson closed 5 years ago

davidjtferguson commented 5 years ago

jab_16

Analise this gif to figure out how come the game kept playing after blue won and fix it.

davidjtferguson commented 5 years ago

looks like what happened is red throws their punch on the same frame they get hit. I've not followed the logic through, but then presumably red's "dead" state was overridden by the "connectlag" state and they continue to not realise that they're dead, and the blue player's "won" state was overridden by the "hitpause" state. So the score counter gets to firstto and says on screen the round should be over, but neither of the avatars know it.

I've shuffled things around and put some checks in so if both players die on the same frame the game shouldn't soft lock. But I need to test it more, due to the fiddilyness of two people dying on the same frame. Need to think through more.

davidjtferguson commented 5 years ago

If health is 0, I enforce death state. Should prevent this from happening, however it's difficult to test so be weary of a regression. If any weirdness around double death occurs, need to capture a gif. but hopefully we're good.