search

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

KB-25100 / Trac-7233 boot disk does not recover after IOVM sp recovery (visorhba upstream) #107

Closed ghost closed 7 years ago

ghost commented 7 years ago

KanBoard-25100 / Trac-7233

selltc commented 7 years ago

removed an extraneous "7" from the KanBoard link: http://ustr-erl-6690.na.uis.unisys.com/?controller=task&action=show&task_id=25100&project_id=377 --> http://ustr-erl-6690.na.uis.unisys.com/?controller=task&action=show&task_id=25100&project_id=37

ghost commented 7 years ago

Branch: githubissue-107-for-later-TurningWrenches Commit(s):

checkpatch-cleared: Yes T710-1 verified: No

selltc commented 7 years ago

I successfully verified David's fix in the githubissue-106-for-later-TurningWrenches branch (which I fitted into the githubissue-106-for-later-201609131535 branch for my testing) on my T110 as described in comment-13 of Trac-7233 and in comment-23 of Trac-7234. So it appears we DID get the "2-for-1 deal", in that the fix for #106 also fixes #107.

Note I also needed commit b1359d11b381ce4aedae021eb5154425872fe64a (remove unnecessary declaration of visorbus_free_irq()) in order to compile cleanly.

ghost commented 7 years ago

Thanks, Tim! I appended that same revision (from my own branch) in GitHub issue #107 (fc44a49d292a00284972f79b7c83d378727bf5f1).

selltc commented 7 years ago

We also need to add commit 34801316e9131ad2ac05dde83e5ec1f8c179e2c4 (staging: unisys: remove redundant unlocks of visornic_devdata.priv_lock) here, in order to fix a problem introduced by commit 2cf63edc44e8b2c467edb41e75ea0727462254f4 (staging: unisys: visornic: Remove errant -EIO returns).

davidker commented 7 years ago

@selltc can we close these or should we wait u til we have patches squashed?

selltc commented 7 years ago

If the fix patches from githubissue-106-for-later-201609131535 branch and commit 34801316e9131ad2ac05dde83e5ec1f8c179e2c4 (staging: unisys: remove redundant unlocks of visornic_devdata.priv_lock) are in for-later, we should close this.