Closed ghost closed 7 years ago
Just so we know what we're working with:
$ grep -rn "sc*nprintf" drivers/staging/unisys/*
drivers/staging/unisys/visorbus/visorbus_main.c:52: return snprintf(buf, PAGE_SIZE, "visorbus:%pUl\n", &guid);
drivers/staging/unisys/visorbus/visorbus_main.c:190: return snprintf(buf, PAGE_SIZE, "0x%llx\n",
drivers/staging/unisys/visorbus/visorbus_main.c:202: return snprintf(buf, PAGE_SIZE, "0x%lx\n",
drivers/staging/unisys/visorbus/visorbus_main.c:214: return snprintf(buf, PAGE_SIZE, "0x%llx\n",
drivers/staging/unisys/visorbus/visorbus_main.c:227: return snprintf(buf, PAGE_SIZE, "%s\n",
drivers/staging/unisys/visorbus/visorbus_main.c:240: return snprintf(buf, PAGE_SIZE, "%s\n",
drivers/staging/unisys/visorbus/visorbus_main.c:260: return snprintf(buf, PAGE_SIZE, "%s\n", drv->channel_types[i - 1].name);
drivers/staging/unisys/visorbus/visorbus_main.c:299: return snprintf(buf, PAGE_SIZE, "0x%llx\n", handle);
drivers/staging/unisys/visorbus/visorbus_main.c:308: return snprintf(buf, PAGE_SIZE, "{%pUb}\n", &vdev->partition_uuid);
drivers/staging/unisys/visorbus/visorbus_main.c:317: return snprintf(buf, PAGE_SIZE, "%s\n", vdev->name);
drivers/staging/unisys/visorbus/visorbus_main.c:327: return snprintf(buf, PAGE_SIZE, "0x%llx\n", addr);
drivers/staging/unisys/visorbus/visorbus_main.c:337: return snprintf(buf, PAGE_SIZE, "0x%llx\n", nbytes);
drivers/staging/unisys/visorbus/visorchipset.c:191: return scnprintf(buf, PAGE_SIZE, "%u\n", tool_action);
drivers/staging/unisys/visorbus/visorchipset.c:226: return scnprintf(buf, PAGE_SIZE, "%u\n",
drivers/staging/unisys/visorbus/visorchipset.c:262: return scnprintf(buf, PAGE_SIZE, "%i\n", error);
drivers/staging/unisys/visorbus/visorchipset.c:295: return scnprintf(buf, PAGE_SIZE, "%i\n", text_id);
drivers/staging/unisys/visorbus/visorchipset.c:327: return scnprintf(buf, PAGE_SIZE, "%hu\n", remaining_steps);
There are other scnprintf's
and snprintf's
in our driver code, but the instances above seem to be the only ones that relate to this issue.
Branch: githubissue-108-upstream-next-TurningWrenches Commit(s): bd230937119e60e26b60d3eae702db6c84238114 checkpatch-cleared: Yes T710-1 verified: Yes
See testing results on internal page.
Can you split this into two patches? One for each file? I would like to put the Reported-by on the one for visorchipset, not the one for visorbus.
Branch: githubissue-108-upstream-next-TurningWrenches Commit(s): 3f185e5095c76fb405f25233f139b69c5f45370f 6aa7db3f392170089596e952e525a31ff3322ba8 checkpatch-cleared: Yes T710-W1 verified: Yes, but also pending response from e-mail "Partition Desktop Behavior"
Update: No longer waiting on this e-mail. Issue presents in 3.10 kernel.
This patch was accepted into the upstream. Closing.
KanBoard-24515
You can't ever be larger than a page, no need to pretend you could be.
same here with scnprintf. Everywhere else too, I'm not going to point them all out.