davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

Use case statement for crash enum #109

Closed ghost closed 7 years ago

ghost commented 7 years ago

KanBoard-24525

 >      if (visorchannel_write(controlvm_channel,
 >                     local_crash_msg_offset,
 >                     msg,
 >                     sizeof(struct controlvm_message)) < 0) {
 >          POSTCODE_LINUX_2(SAVE_MSG_BUS_FAILURE_PC,
 >                   POSTCODE_SEVERITY_ERR);
 >          return;
 >      }
 >  } else {
 >      local_crash_msg_offset += sizeof(struct controlvm_message);
 >      if (visorchannel_write(controlvm_channel,
 >                     local_crash_msg_offset,
 >                     msg,
 >                     sizeof(struct controlvm_message)) < 0) {
 >          POSTCODE_LINUX_2(SAVE_MSG_DEV_FAILURE_PC,
 >                   POSTCODE_SEVERITY_ERR);
 >          return;
 >      }

So an enum yet you don't check the other value? case statement perhaps?

ghost commented 7 years ago

Branch: githubissue-109-upstream-next-TurningWrenches Commit(s): 2a04c5403b78abeff8c1e1c891f6db7aeea5a83f checkpatch-cleared: Yes T710-W1 verified: Yes, but also pending response from e-mail "Partition Desktop Behavior"

Update: No longer waiting on this e-mail. Issue presents in 3.10 kernel.

davidker commented 7 years ago

Was this built off of for-later?

ghost commented 7 years ago

That should say "upstream-next". Sorry about the typo :(

UPDATE: Fixed.

davidker commented 7 years ago

Closed committed at 36309d3b105c650eb0398afd1675df30fb570e5d