davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

Get rid of visorchipset_release functions #110

Closed ghost closed 7 years ago

ghost commented 7 years ago

KanBoard-24494

 >  return 0;
 > }
 > 
 > static int
 > visorchipset_release(struct inode *inode, struct file *file)
 > {
 >  return 0;
 > }

If you do nothing in a release function, then don't provide it at all.

ghost commented 7 years ago

Branch: githubissue-110-for-later-TurningWrenches Commit(s): 9cc183333f5d562669970961e1baf906ccff4fe4 checkpatch-cleared: Yes T710-1 verified: Yes

$ grep -rn "visorchipset_release" drivers/staging/unisys/* | wc -l
0
$ grep -rn "visorchipset_dev_release" drivers/staging/unisys/* | wc -l
0
ghost commented 7 years ago

@davidker

Do you remember where we left this?

davidker commented 7 years ago

Do we still have it? My belief is we got rid of the things that required us to have a release function so it just disappeared. We can close this.