Explain logic in bus_destroy()

[ghost]

 >  }
 > 
 >  INIT_LIST_HEAD(&bus_info->list_all);
 >  bus_info->chipset_bus_no = bus_no;
 >  bus_info->chipset_dev_no = BUS_ROOT_DEVICE;
 > 
 >  POSTCODE_LINUX_3(BUS_CREATE_ENTRY_PC, bus_no, POSTCODE_SEVERITY_INFO);
 > 
 >  visorchannel = visorchannel_create(cmd->create_bus.channel_addr,
 >                     cmd->create_bus.channel_bytes,
 >                     GFP_KERNEL,
 >                     cmd->create_bus.bus_data_type_uuid);
 > 
 >  if (!visorchannel) {
 >      POSTCODE_LINUX_3(BUS_CREATE_FAILURE_PC, bus_no,
 >               POSTCODE_SEVERITY_ERR);
 >      rc = -CONTROLVM_RESP_ERROR_KMALLOC_FAILED;
 >      kfree(bus_info);
 >      bus_info = NULL;
 >      goto out_bus_epilog;
 >  }
 >  bus_info->visorchannel = visorchannel;
 >  if (uuid_le_cmp(cmd->create_bus.bus_inst_uuid, spar_siovm_uuid) == 0) {
 >      dump_vhba_bus = bus_no;
 >      save_crash_message(inmsg, CRASH_BUS);
 >  }
 > 
 >  POSTCODE_LINUX_3(BUS_CREATE_EXIT_PC, bus_no, POSTCODE_SEVERITY_INFO);
 > 
 > out_bus_epilog:
 >  bus_epilog(bus_info, CONTROLVM_BUS_CREATE, &inmsg->hdr,
 >         rc, inmsg->hdr.flags.response_expected == 1);
 > }
 > 
 > static void
 > bus_destroy(struct controlvm_message *inmsg)
 > {
 >  struct controlvm_message_packet *cmd = &inmsg->cmd;
 >  u32 bus_no = cmd->destroy_bus.bus_no;
 >  struct visor_device *bus_info;
 >  int rc = CONTROLVM_RESP_SUCCESS;
 > 
 >  bus_info = visorbus_get_device_by_id(bus_no, BUS_ROOT_DEVICE, NULL);
 >  if (!bus_info)
 >      rc = -CONTROLVM_RESP_ERROR_BUS_INVALID;

How can this happen?

[ghost]

Branch: githubissue-116-upstream-next-TurningWrenches Commit(s): 3b74c870411ff00c3ae6fcb5c704d5b531bff57a e166e43709fa48800cd6bb5087a90413d8cf5973 995388892178fc90835eea2b4bc48babf467ab1f checkpatch-cleared: Yes T710-W1 verified: Yes

[davidker]

Tim sent email after patch was denied.