search

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

Nits in initialize/destroy_controlvm_payload_info() #124

Closed davidker closed 7 years ago

davidker commented 7 years ago

Task #24543

davidker commented 7 years ago

Realized they aren't actually being used just created and destroyed. So we can get rid of it. Patch is located on branch githubissue-124-upstream-next with the patch: 08a82575d406cb74e17ccfcd1a61923e9f2693ee.

ghost commented 7 years ago

So I understand what your patch is doing, and it looks fine to me. My only comment is to refine the commit message a bit more. When I read it, I don't make the connection that visor_controlvm_payload_info has anything to do with sending payloads back to the s-Par firmware. I might say something to the effect of "Removing visor_controlvm_payload_info structure, which was used to send payloads back to the s-Par firmware, because we do not implement that functionality."

davidker commented 7 years ago

Committed at d308d2b