Open wadgaonkarsam opened 7 years ago
Branch: githubissue-128 Commit(s): 1775f2106706dfbbba2a3fb63c8ebf3e4870a3c6 ed9a2d7e264748dd7886a383da14a6d6fff53996 4cbf9173f535092caf1cea20fe7b4288a6bf84b9 9c059e713a2c54d3b4f0fe9e7bde6c843272e9e7 0a4899e3a88854b963626420d6e0782f8c19807a 7eb1b3a4a96cba49b16d119a7cf7af3a1b4cd876 7606b2cece740a6e5a73be0ba54e4266840ffa5b checkpatch-cleared: Yes T710-W1-AutoTest verified: Yes
Sameer, I'm going through channel.h and I see a lot of places where describing with namespace can improve it. I'm wondering if we should look at this file as well.
Patch: staging: unisys: visorbus: vbuschannel.h: renamed #defines and structures to match driver namespace
Can you split it up into #defines and structures?
Same with the controlvmchannel.h one as well.
And for channel.h (even though it makes one patch extremely small)
I noticed a couple of things with the current githubissue-128 branch. We missed the Documentation directory and I think we should drop protocol from the channel names.
Kanboard:29383
And that's a horrid global function name, please use your own namespace.
same here, use your own namespace.
same namespace issue.
namespace...
namespace...
namespace, errors, etc...