davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

No comments on the right #131

Open wadgaonkarsam opened 7 years ago

wadgaonkarsam commented 7 years ago

At first I thought Greg didn't like comments on the same line as code, but now I think all he is complaining about is that there is more than 1 space between the ';' and the comment. Note there are several instance of this. Fix them all.

}

static void
bus_responder(enum controlvm_id cmd_id,
          struct controlvm_message_header *pending_msg_hdr,
          int response)
{
    if (!pending_msg_hdr)
        return;     /* no controlvm response needed */

No comments on the right please.

Here's another one:

static void
device_changestate_responder(enum controlvm_id cmd_id,
                          struct visor_device *p, int response,
                          struct spar_segment_state response_state)
{
     struct controlvm_message outmsg;
     u32 bus_no = p->chipset_bus_no;
     u32 dev_no = p->chipset_dev_no;

     if (!p->pending_msg_hdr)
             return;         /* no controlvm response needed */
     if (p->pending_msg_hdr->id != cmd_id)
             return;

again with the right comments and no errors :(