visorchannel.nbytes vs visorchannel.size[upstream]

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus

Other

2 stars 1 forks source link

visorchannel.nbytes vs visorchannel.size[upstream] #18

Closed AlexanderCurtin closed 8 years ago

AlexanderCurtin commented 8 years ago

The visorchannel struct both has nbytes and bytes. Both are set to the allocated bytes for the channel. They seem to be used interchangeably. Why?

selltc commented 8 years ago

I think one of the fields is indeed extraneous, and we should fix the code to use one or the other.

AlexanderCurtin commented 8 years ago

Looking back on it, the two attributes are `visorchannel.nbytes' and 'visorchannel.size'.

ghost commented 8 years ago

The issue is repaired:

branch: visorchannel_nbytes_v_size_issue, commit 134a8f0
checkpatch-cleared: yes
T710-1 verified: yes

davidker commented 8 years ago

David,

I switched the title of the patch to staging: Unisys: visorchannel: remove redundant member size

The previous headline was dealing too much with "issue" which I don't think makes sense in the kernel logs. Let me know if you have problems with the changed. It is currently in upstream-next and being processed.

ghost commented 8 years ago

The new title looks great!