search

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

visorhba: visorhba_probe(): what happens if we probe more than 1 (VISORHBA_OPEN_MAX) devices?[upstream] #39

Closed selltc closed 8 years ago

selltc commented 8 years ago

Source: Dan Carpenter dan.carpenter@oracle.com Mon 5/2/2016 5:53 AM

visorhba_probe(). We really can only probe one device right? Because VISORHBA_OPEN_MAX is

  1. So what happens if we try to probe two? I don't immediately see how that is handled.

See KanBoard-997

selltc commented 8 years ago

I have addressed this in commit 3d04956323d17676240608a5845ce2cbf4190fa0 and commit 65e2016b8a026bdaf1a51653997cd0944826bed0, but this patchset also inevitably depends on other patches currently in mid-fllight.

[PATCH 0/2] staging: unisys: visorhba: debugfs cleanup, remove unused globals

This patchset simplifies and enhances the visorhba debugfs interface, and
deletes a global array made no-longer-necessary by the cleanup.
selltc commented 8 years ago

Oh yeah, those patches also both are checkpatch and regression clean.

selltc commented 8 years ago

Greg added these to staging-testing, then to staging-next a few hours later: