search

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

visornic: visor_copy_fragsinfo_from_skb(): `ii` variable name is ugly and misleading[staging-testing] #41

Closed selltc closed 8 years ago

selltc commented 8 years ago 
212  static int
213  visor_copy_fragsinfo_from_skb(struct sk_buff *skb, unsigned int firstfraglen,
214                                unsigned int frags_max,
215                                struct phys_info frags[])
216  {
217          unsigned int count = 0, ii, size, offset = 0, numfrags;
                                     ^^

Source: Dan Carpenter dan.carpenter@oracle.com Mon 5/2/2016 5:53 AM

The second "i" character indicates that it is an integer. Which is ugly and, of course, misleading.

See KanBoard-999

selltc commented 8 years ago

Greg committed this to staging-testing 5/6, and later to staging-next on 5/9: