visornic: enable_ints_write(): let's get rid of this debugfs interface

296  static ssize_t enable_ints_write(struct file *file,
297                                   const char __user *buffer,
298                                   size_t count, loff_t *ppos)
299  {
300          /*
301           * Don't want to break ABI here by having a debugfs
302           * file that no longer exists or is writable, so
303           * lets just make this a vestigual function
304           */
305          return count;
306  }

Source: Dan Carpenter dan.carpenter@oracle.com Mon 5/2/2016 5:53 AM

We don't care about ABI so much as we do about applications or scripts. This was added by Neil Horman because the original code was useless and dangerous. It was the right patch for him, because he doesn't know about the userspace so he can't say if anything will break. But presumably you guys know. Does anything break if we remove this debugfs file?

Also if so then shame shame shame. User space is not supposed to depend on debugfs being writable. Just delete this...

See KanBoard-1000

davidker / unisys

visornic: enable_ints_write(): let's get rid of this debugfs interface #42