davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

visornic: visornic_set_multi(): simplify if statement[upstream] #43

Closed selltc closed 8 years ago

selltc commented 8 years ago
1019   */
1020  static void
1021  visornic_set_multi(struct net_device *netdev)
1022  {
1023          struct uiscmdrsp *cmdrsp;
1024          struct visornic_devdata *devdata = netdev_priv(netdev);
1025  
1026          /* any filtering changes */
1027          if (devdata->old_flags != netdev->flags) {
1028                  if ((netdev->flags & IFF_PROMISC) !=
1029                      (devdata->old_flags & IFF_PROMISC)) {

Source: Dan Carpenter dan.carpenter@oracle.com Mon 5/2/2016 5:53 AM

Reverse these if statements and pull the code in two indent levels.

See KanBoard-1001

ghost commented 8 years ago

branch: visornic_simplify_if, commit 7f43241 checkpatch-cleared: yes T710-1 verified: yes

selltc commented 8 years ago

This patch looks good to me. Feel free to mark:

Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
selltc commented 8 years ago

6/8 - Greg committed this to staging-testing and staging-next: