davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

visorinput: handle_locking_key(): just 'return' rather than 'led = -1', then remove subsequent test of led #48

Closed selltc closed 8 years ago

selltc commented 8 years ago

Source: Dan Carpenter dan.carpenter@oracle.com Mon 5/2/2016 5:53 AM

465          case KEY_NUMLOCK:
466                  led = LED_NUML;
467                  break;
468          default:
469                  led = -1;

Just make this a direct return.

470                  break;
471          }
472          if (led >= 0) {

Then you can remove this if condition.

See KanBoard-1006

selltc commented 8 years ago

Fixed by commit cc2f5a4b55ffeee565367a84c39df4abb939f63a.

selltc commented 8 years ago

Greg posted this to his staging-testing on 5/6, and later to staging-next on 5/9: