davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus
Other
2 stars 1 forks source link

'for-later' interrupts do NOT work in SLES12.0 or RHEL7.2 #54

Closed selltc closed 7 years ago

selltc commented 8 years ago

KanBoard-979

selltc commented 8 years ago

Fixed by commit 57781f99da5a8cb7ae3c1898c9dfb42f7f87111b. I verified I can boot up the for-later branch with SLES12.0 and RHEL7.2 using this patch. I'll figure out where the for-later branch soon...

selltc commented 8 years ago

If I had to take a guess, I would say that it is commit 527c0b19700536f86c758c12f00b9d48bc7ee194 that is at fault, because that is where channel_interrupt SHOULD have first been assigned a value of visorhba_isr(), but was NOT. I.e., I think this is a mistake where a necessary change was omitted, rather than a change that messed it up.

selltc commented 8 years ago

I went ahead and committed this to our for-later svn mirror in r29725.

davidker commented 8 years ago

Thanks! I've incorporated it into for-later which should be up later today.

selltc commented 8 years ago

Thanks David. I now see this fixed in your revised for-later commit 42e3e0a8394e481c0991639bbaac12beee2901f2.

selltc commented 8 years ago

In today's version of for-later, verified this is in commit 370f552ac18b871470d55295e4065c556ffc559d.

davidker commented 7 years ago

@selltc, can we close this? Or do we keep this open to do checks?

michael-didomenico commented 7 years ago

I can't figure why we didn't close this a long time ago...

selltc commented 7 years ago

(Sorry... I was accidentally logged in to Mike's account before, as I need that to access SDG's github...) I can't figure why we didn't close this a long time ago...

davidker commented 7 years ago

Closing.. okay I was really confused there for a second.