visorbus_private.h called visorchipset.h internally

davidker / unisys

Master repository for new changes to drivers/staging/unisys and drivers/visorbus

Other

2 stars 1 forks source link

visorbus_private.h called visorchipset.h internally #67

Closed mriswyth closed 7 years ago

mriswyth commented 8 years ago

visorbus_private.h is labelled as visorchipset.h at the top of the header. Its include protection wrapper is also VISORCHIPSET_H.

There are also places where visorchipset is referred to that may need to be changed to visorbus or made explicitly visorchipset.c.

KanBan-1340

ghost commented 8 years ago

Branch: visorbus_fix_header_names; commits: 3acea575389eefebaf3f0b64a09a2b80e69e5c95, 7d0ce58f45f7f91f5a9fe4c51af55642c31f851b Upstream: upstream-next checkpatch-cleared: yes T710-1 verified: yes

selltc commented 8 years ago

Other than a typo in the commit e7cc3264cd79fd648efe10c29f22fab3b5295cbc log comment: "longe" --> "longer", this looks fine.

You might also shorten the commit adccee33c456716ccbb98b789e2e0d1458f705be headline to 72 characters, but I'm not sure that's a submission requirement. (I know github is more friendly with 72 characters for some reason.)

ghost commented 8 years ago

Thanks, Tim! I've implemented the changes you suggested, and updated the SHA1s.

selltc commented 8 years ago

Thanks David; looks good.

selltc commented 8 years ago

Greg committed one of these patches to staging-next on 9/12 as:

commit 7339cb09a91ea316b6b84944910a2869abfc7fea staging: unisys: visorbus: Convert visorchipset.h refs

But I do NOT see the "staging: unisys: visorbus: Convert references to /proc to /sys" patch committed anywhere yet, so I'm leaving this issue open for now.

davidker commented 7 years ago

Sorry I missed 7d0ce58. I will try to figure out what happened and submit it upstream.

davidker commented 7 years ago

It was committed as patch 5d501ef